Remove rtmp (#8941)

* remove rtmp from python

* remove rtmp from nginx

* remove rtmp from docs

* fix test for missing role

frigate/config.py

@@ -30,7 +30,6 @@ from frigate.ffmpeg_presets import (
     parse_preset_hardware_acceleration_scale,
     parse_preset_input,
     parse_preset_output_record,
-    parse_preset_output_rtmp,
 )
 from frigate.plus import PlusApi
 from frigate.util.builtin import (
@@ -582,7 +581,6 @@ DETECT_FFMPEG_OUTPUT_ARGS_DEFAULT = [
     "-pix_fmt",
     "yuv420p",
 ]
-RTMP_FFMPEG_OUTPUT_ARGS_DEFAULT = "preset-rtmp-generic"
 RECORD_FFMPEG_OUTPUT_ARGS_DEFAULT = "preset-record-generic"
 
 
@@ -595,10 +593,6 @@ class FfmpegOutputArgsConfig(FrigateBaseModel):
         default=RECORD_FFMPEG_OUTPUT_ARGS_DEFAULT,
         title="Record role FFmpeg output arguments.",
     )
-    rtmp: Union[str, List[str]] = Field(
-        default=RTMP_FFMPEG_OUTPUT_ARGS_DEFAULT,
-        title="RTMP role FFmpeg output arguments.",
-    )
 
 
 class FfmpegConfig(FrigateBaseModel):
@@ -624,7 +618,6 @@ class FfmpegConfig(FrigateBaseModel):
 class CameraRoleEnum(str, Enum):
     audio = "audio"
     record = "record"
-    rtmp = "rtmp"
     detect = "detect"
 
 
@@ -733,10 +726,6 @@ class CameraMqttConfig(FrigateBaseModel):
     )
 
 
-class RtmpConfig(FrigateBaseModel):
-    enabled: bool = Field(default=False, title="RTMP restreaming enabled.")
-
-
 class CameraLiveConfig(FrigateBaseModel):
     stream_name: str = Field(default="", title="Name of restream to use as live view.")
     height: int = Field(default=720, title="Live camera view height")
@@ -772,9 +761,6 @@ class CameraConfig(FrigateBaseModel):
     record: RecordConfig = Field(
         default_factory=RecordConfig, title="Record configuration."
     )
-    rtmp: RtmpConfig = Field(
-        default_factory=RtmpConfig, title="RTMP restreaming configuration."
-    )
     live: CameraLiveConfig = Field(
         default_factory=CameraLiveConfig, title="Live playback settings."
     )
@@ -819,7 +805,6 @@ class CameraConfig(FrigateBaseModel):
 
         # add roles to the input if there is only one
         if len(config["ffmpeg"]["inputs"]) == 1:
-            has_rtmp = "rtmp" in config["ffmpeg"]["inputs"][0].get("roles", [])
             has_audio = "audio" in config["ffmpeg"]["inputs"][0].get("roles", [])
 
             config["ffmpeg"]["inputs"][0]["roles"] = [
@@ -830,9 +815,6 @@ class CameraConfig(FrigateBaseModel):
             if has_audio:
                 config["ffmpeg"]["inputs"][0]["roles"].append("audio")
 
-            if has_rtmp:
-                config["ffmpeg"]["inputs"][0]["roles"].append("rtmp")
-
         super().__init__(**config)
 
     @property
@@ -872,15 +854,7 @@ class CameraConfig(FrigateBaseModel):
             )
 
             ffmpeg_output_args = scale_detect_args + ffmpeg_output_args + ["pipe:"]
-        if "rtmp" in ffmpeg_input.roles and self.rtmp.enabled:
-            rtmp_args = get_ffmpeg_arg_list(
-                parse_preset_output_rtmp(self.ffmpeg.output_args.rtmp)
-                or self.ffmpeg.output_args.rtmp
-            )
 
-            ffmpeg_output_args = (
-                rtmp_args + [f"rtmp://127.0.0.1/live/{self.name}"] + ffmpeg_output_args
-            )
         if "record" in ffmpeg_input.roles and self.record.enabled:
             record_args = get_ffmpeg_arg_list(
                 parse_preset_output_record(self.ffmpeg.output_args.record)
@@ -967,11 +941,6 @@ def verify_config_roles(camera_config: CameraConfig) -> None:
             f"Camera {camera_config.name} has record enabled, but record is not assigned to an input."
         )
 
-    if camera_config.rtmp.enabled and "rtmp" not in assigned_roles:
-        raise ValueError(
-            f"Camera {camera_config.name} has rtmp enabled, but rtmp is not assigned to an input."
-        )
-
     if camera_config.audio.enabled and "audio" not in assigned_roles:
         raise ValueError(
             f"Camera {camera_config.name} has audio events enabled, but audio is not assigned to an input."
@@ -1082,9 +1051,6 @@ class FrigateConfig(FrigateBaseModel):
     snapshots: SnapshotsConfig = Field(
         default_factory=SnapshotsConfig, title="Global snapshots configuration."
     )
-    rtmp: RtmpConfig = Field(
-        default_factory=RtmpConfig, title="Global RTMP restreaming configuration."
-    )
     live: CameraLiveConfig = Field(
         default_factory=CameraLiveConfig, title="Live playback settings."
     )
@@ -1138,7 +1104,6 @@ class FrigateConfig(FrigateBaseModel):
                 "birdseye": ...,
                 "record": ...,
                 "snapshots": ...,
-                "rtmp": ...,
                 "live": ...,
                 "objects": ...,
                 "motion": ...,
@@ -1272,11 +1237,6 @@ class FrigateConfig(FrigateBaseModel):
             verify_zone_objects_are_tracked(camera_config)
             verify_autotrack_zones(camera_config)
 
-            if camera_config.rtmp.enabled:
-                logger.warning(
-                    "RTMP restream is deprecated in favor of the restream role, recommend disabling RTMP."
-                )
-
             # generate the ffmpeg commands
             camera_config.create_ffmpeg_cmds()
             config.cameras[name] = camera_config