Add isort and ruff linter (#6575)

* Add isort and ruff linter

Both linters are pretty common among modern python code bases.

The isort tool provides stable sorting and grouping, as well as pruning
of unused imports.

Ruff is a modern linter, that is very fast due to being written in rust.
It can detect many common issues in a python codebase.

Removes the pylint dev requirement, since ruff replaces it.

* treewide: fix issues detected by ruff

* treewide: fix bare except clauses

* .devcontainer: Set up isort

* treewide: optimize imports

* treewide: apply black

* treewide: make regex patterns raw strings

This is necessary for escape sequences to be properly recognized.

frigate/detectors/__init__.py

@@ -1,13 +1,7 @@
 import logging
 
-from .detection_api import DetectionApi
-from .detector_config import (
-    PixelFormatEnum,
-    InputTensorEnum,
-    ModelConfig,
-)
-from .detector_types import DetectorTypeEnum, api_types, DetectorConfig
-
+from .detector_config import InputTensorEnum, ModelConfig, PixelFormatEnum  # noqa: F401
+from .detector_types import DetectorConfig, DetectorTypeEnum, api_types  # noqa: F401
 
 logger = logging.getLogger(__name__)
 

frigate/detectors/detection_api.py

@@ -1,7 +1,6 @@
 import logging
 from abc import ABC, abstractmethod
 
-
 logger = logging.getLogger(__name__)
 
 

frigate/detectors/detector_config.py

@@ -1,20 +1,18 @@
 import hashlib
 import json
 import logging
-from enum import Enum
 import os
-from typing import Dict, List, Optional, Tuple, Union, Literal
+from enum import Enum
+from typing import Dict, Optional, Tuple
 
-
-import requests
 import matplotlib.pyplot as plt
-from pydantic import BaseModel, Extra, Field, validator
+import requests
+from pydantic import BaseModel, Extra, Field
 from pydantic.fields import PrivateAttr
+
 from frigate.plus import PlusApi
-
 from frigate.util import load_labels
 
-
 logger = logging.getLogger(__name__)
 
 

frigate/detectors/detector_types.py

@@ -1,16 +1,16 @@
-import logging
 import importlib
+import logging
 import pkgutil
-from typing import Union
-from typing_extensions import Annotated
 from enum import Enum
+from typing import Union
+
 from pydantic import Field
+from typing_extensions import Annotated
 
 from . import plugins
 from .detection_api import DetectionApi
 from .detector_config import BaseDetectorConfig
 
-
 logger = logging.getLogger(__name__)
 
 

frigate/detectors/plugins/cpu_tfl.py

@@ -1,10 +1,11 @@
 import logging
+
 import numpy as np
+from pydantic import Field
+from typing_extensions import Literal
 
 from frigate.detectors.detection_api import DetectionApi
 from frigate.detectors.detector_config import BaseDetectorConfig
-from typing_extensions import Literal
-from pydantic import Extra, Field
 
 try:
     from tflite_runtime.interpreter import Interpreter

frigate/detectors/plugins/deepstack.py

@@ -1,14 +1,14 @@
+import io
 import logging
+
 import numpy as np
 import requests
-import io
+from PIL import Image
+from pydantic import Field
+from typing_extensions import Literal
 
 from frigate.detectors.detection_api import DetectionApi
 from frigate.detectors.detector_config import BaseDetectorConfig
-from typing_extensions import Literal
-from pydantic import Extra, Field
-from PIL import Image
-
 
 logger = logging.getLogger(__name__)
 
@@ -64,11 +64,11 @@ class DeepStack(DetectionApi):
         for i, detection in enumerate(response_json.get("predictions")):
             logger.debug(f"Response: {detection}")
             if detection["confidence"] < 0.4:
-                logger.debug(f"Break due to confidence < 0.4")
+                logger.debug("Break due to confidence < 0.4")
                 break
             label = self.get_label_index(detection["label"])
             if label < 0:
-                logger.debug(f"Break due to unknown label")
+                logger.debug("Break due to unknown label")
                 break
             detections[i] = [
                 label,

frigate/detectors/plugins/edgetpu_tfl.py

@@ -1,10 +1,11 @@
 import logging
+
 import numpy as np
+from pydantic import Field
+from typing_extensions import Literal
 
 from frigate.detectors.detection_api import DetectionApi
 from frigate.detectors.detector_config import BaseDetectorConfig
-from typing_extensions import Literal
-from pydantic import Extra, Field
 
 try:
     from tflite_runtime.interpreter import Interpreter, load_delegate

frigate/detectors/plugins/openvino.py

@@ -1,12 +1,12 @@
 import logging
+
 import numpy as np
 import openvino.runtime as ov
+from pydantic import Field
+from typing_extensions import Literal
 
 from frigate.detectors.detection_api import DetectionApi
 from frigate.detectors.detector_config import BaseDetectorConfig, ModelTypeEnum
-from typing_extensions import Literal
-from pydantic import Extra, Field
-
 
 logger = logging.getLogger(__name__)
 
@@ -41,7 +41,7 @@ class OvDetector(DetectionApi):
                 tensor_shape = self.interpreter.output(self.output_indexes).shape
                 logger.info(f"Model Output-{self.output_indexes} Shape: {tensor_shape}")
                 self.output_indexes += 1
-            except:
+            except Exception:
                 logger.info(f"Model has {self.output_indexes} Output Tensors")
                 break
         if self.ov_model_type == ModelTypeEnum.yolox:

frigate/detectors/plugins/tensorrt.py

@@ -1,6 +1,6 @@
+import ctypes
 import logging
 
-import ctypes
 import numpy as np
 
 try:
@@ -8,13 +8,14 @@ try:
     from cuda import cuda
 
     TRT_SUPPORT = True
-except ModuleNotFoundError as e:
+except ModuleNotFoundError:
     TRT_SUPPORT = False
 
+from pydantic import Field
+from typing_extensions import Literal
+
 from frigate.detectors.detection_api import DetectionApi
 from frigate.detectors.detector_config import BaseDetectorConfig
-from typing_extensions import Literal
-from pydantic import Field
 
 logger = logging.getLogger(__name__)
 
@@ -172,7 +173,7 @@ class TensorRtDetector(DetectionApi):
         if not self.context.execute_async_v2(
             bindings=self.bindings, stream_handle=self.stream
         ):
-            logger.warn(f"Execute returned false")
+            logger.warn("Execute returned false")
 
         # Transfer predictions back from the GPU.
         [