Reduce rerenders on some components (#10068)

* Remove direct callback

* don't rerender for callback

* Move websocket to top level events

* Be smarter about updating timeago

* Cleanup
This commit is contained in:
Nicolas Mowen
2024-02-26 15:08:55 -07:00
committed by GitHub
parent e9076c0213
commit 849f343b25
5 changed files with 141 additions and 49 deletions

View File

@@ -1,3 +1,4 @@
import { useFrigateEvents } from "@/api/ws";
import useApiFilter from "@/hooks/use-api-filter";
import useOverlayState from "@/hooks/use-overlay-state";
import { ReviewFilter, ReviewSegment } from "@/types/review";
@@ -5,7 +6,7 @@ import DesktopEventView from "@/views/events/DesktopEventView";
import DesktopRecordingView from "@/views/events/DesktopRecordingView";
import MobileEventView from "@/views/events/MobileEventView";
import axios from "axios";
import { useCallback, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { isMobile } from "react-device-detect";
import useSWR from "swr";
import useSWRInfinite from "swr/infinite";
@@ -92,6 +93,10 @@ export default function Events() {
[reviewPages]
);
const onLoadNextPage = useCallback(() => {
setSize(size + 1);
}, [size]);
// preview videos
const previewTimes = useMemo(() => {
@@ -189,6 +194,25 @@ export default function Events() {
};
}, [selectedReviewId, reviewPages]);
// review updates
const { payload: eventUpdate } = useFrigateEvents();
const [hasUpdate, setHasUpdate] = useState(false);
useEffect(() => {
if (!eventUpdate) {
return;
}
// if event is ended and was saved, update events list
if (
eventUpdate.type == "end" &&
(eventUpdate.after.has_clip || eventUpdate.after.has_snapshot)
) {
setHasUpdate(true);
return;
}
}, [eventUpdate]);
if (selectedData) {
return (
<DesktopRecordingView
@@ -205,8 +229,11 @@ export default function Events() {
relevantPreviews={allPreviews}
reachedEnd={isDone}
isValidating={isValidating}
loadNextPage={() => setSize(size + 1)}
hasUpdate={hasUpdate}
setHasUpdate={setHasUpdate}
loadNextPage={onLoadNextPage}
markItemAsReviewed={markItemAsReviewed}
pullLatestData={updateSegments}
/>
);
}
@@ -219,7 +246,9 @@ export default function Events() {
reachedEnd={isDone}
isValidating={isValidating}
filter={reviewFilter}
loadNextPage={() => setSize(size + 1)}
hasUpdate={hasUpdate}
setHasUpdate={setHasUpdate}
loadNextPage={onLoadNextPage}
markItemAsReviewed={markItemAsReviewed}
onSelectReview={setSelectedReviewId}
pullLatestData={updateSegments}