Configurable ffmpeg (#13722)

* Install multiple ffmpeg versions and add config to make it configurable

* Update docs

* Run ffprobe too

* Cleanup

* Apply config to go2rtc as well

* Fix ffmpeg bin

* Docs

* Restore path

* Cleanup env var

* Fix ffmpeg path for encoding

* Fix export

* Formatting

frigate/output/birdseye.py

@@ -15,7 +15,7 @@ import cv2
 import numpy as np
 
 from frigate.comms.config_updater import ConfigSubscriber
-from frigate.config import BirdseyeModeEnum, FrigateConfig
+from frigate.config import BirdseyeModeEnum, FfmpegConfig, FrigateConfig
 from frigate.const import BASE_DIR, BIRDSEYE_PIPE
 from frigate.util.image import (
     SharedMemoryFrameManager,
@@ -112,7 +112,7 @@ class Canvas:
 class FFMpegConverter(threading.Thread):
     def __init__(
         self,
-        camera: str,
+        ffmpeg: FfmpegConfig,
         input_queue: queue.Queue,
         stop_event: mp.Event,
         in_width: int,
@@ -123,8 +123,8 @@ class FFMpegConverter(threading.Thread):
         birdseye_rtsp: bool = False,
     ):
         threading.Thread.__init__(self)
-        self.name = f"{camera}_output_converter"
-        self.camera = camera
+        self.name = "birdseye_output_converter"
+        self.camera = "birdseye"
         self.input_queue = input_queue
         self.stop_event = stop_event
         self.bd_pipe = None
@@ -133,7 +133,7 @@ class FFMpegConverter(threading.Thread):
             self.recreate_birdseye_pipe()
 
         ffmpeg_cmd = [
-            "ffmpeg",
+            ffmpeg.ffmpeg_path,
             "-threads",
             "1",
             "-f",
@@ -725,7 +725,7 @@ class Birdseye:
         self.config = config
         self.input = queue.Queue(maxsize=10)
         self.converter = FFMpegConverter(
-            "birdseye",
+            config.ffmpeg,
             self.input,
             stop_event,
             config.birdseye.width,

frigate/output/camera.py

@@ -6,7 +6,7 @@ import queue
 import subprocess as sp
 import threading
 
-from frigate.config import CameraConfig
+from frigate.config import CameraConfig, FfmpegConfig
 
 logger = logging.getLogger(__name__)
 
@@ -15,6 +15,7 @@ class FFMpegConverter(threading.Thread):
     def __init__(
         self,
         camera: str,
+        ffmpeg: FfmpegConfig,
         input_queue: queue.Queue,
         stop_event: mp.Event,
         in_width: int,
@@ -30,7 +31,7 @@ class FFMpegConverter(threading.Thread):
         self.stop_event = stop_event
 
         ffmpeg_cmd = [
-            "ffmpeg",
+            ffmpeg.ffmpeg_path,
             "-threads",
             "1",
             "-f",
@@ -142,6 +143,7 @@ class JsmpegCamera:
         )
         self.converter = FFMpegConverter(
             config.name,
+            config.ffmpeg,
             self.input,
             stop_event,
             config.frame_shape[1],

frigate/output/preview.py

@@ -78,6 +78,7 @@ class FFMpegConverter(threading.Thread):
 
         # write a PREVIEW at fps and 1 key frame per clip
         self.ffmpeg_cmd = parse_preset_hardware_acceleration_encode(
+            config.ffmpeg.ffmpeg_path,
             config.ffmpeg.hwaccel_args,
             input="-f concat -y -protocol_whitelist pipe,file -safe 0 -threads 1 -i /dev/stdin",
             output=f"-threads 1 -g {PREVIEW_KEYFRAME_INTERVAL} -bf 0 -b:v {PREVIEW_QUALITY_BIT_RATES[self.config.record.preview.quality]} {FPS_VFR_PARAM} -movflags +faststart -pix_fmt yuv420p {self.path}",