* Ensure review and search item mobile pages reopen correctly

* disable pan/pinch/zoom when native browser video controls are displayed

* report 0 for storage usage when api returns null
This commit is contained in:
Josh Hawkins
2024-10-25 07:24:04 -05:00
committed by GitHub
parent 2d27e72ed9
commit 4dadf6d353
5 changed files with 44 additions and 23 deletions

View File

@@ -109,6 +109,20 @@ export default function SearchDetailDialog({
const [isOpen, setIsOpen] = useState(search != undefined);
const handleOpenChange = useCallback(
(open: boolean) => {
setIsOpen(open);
if (!open) {
// short timeout to allow the mobile page animation
// to complete before updating the state
setTimeout(() => {
setSearch(undefined);
}, 300);
}
},
[setSearch],
);
useEffect(() => {
if (search) {
setIsOpen(search != undefined);
@@ -158,14 +172,7 @@ export default function SearchDetailDialog({
const Description = isDesktop ? DialogDescription : MobilePageDescription;
return (
<Overlay
open={isOpen}
onOpenChange={() => {
if (search) {
setSearch(undefined);
}
}}
>
<Overlay open={isOpen} onOpenChange={handleOpenChange}>
<Content
className={cn(
"scrollbar-container overflow-y-auto",
@@ -174,7 +181,7 @@ export default function SearchDetailDialog({
isMobile && "px-4",
)}
>
<Header onClose={() => setIsOpen(false)}>
<Header>
<Title>Tracked Object Details</Title>
<Description className="sr-only">Tracked object details</Description>
</Header>